Adjust SVG in OT scaling and baseline.#106584
Merged
Merged
Conversation
|
I tested this, it's much improved. But an issue mentioned in #98211 remains: there's a slight vertical shift when there are only emojis compared to when there are emojis mixed with text. 2025-05-19_13-41-15.mp4 |
Member
Author
This looks expected, different fonts have different height, and height of the label depends on its content (in this particular case, baseline of hex boxes might need adjustment as well, but it's not related to SVG). |
akien-mga
approved these changes
May 19, 2025
Contributor
|
Thanks! |
Contributor
|
This is excellent, but doesn't seem to have fixed #80766 using system emoji on MacOS. |
Member
Author
macOS system emoji font is bitmap not SVG, so it is a separate issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #106429
Fixes #80766
Fixes #98211
Before:

After:
