Skip to content

Adjust SVG in OT scaling and baseline.#106584

Merged
Repiteo merged 1 commit into
godotengine:masterfrom
bruvzg:svg_in_ot_sc_and_bl
May 19, 2025
Merged

Adjust SVG in OT scaling and baseline.#106584
Repiteo merged 1 commit into
godotengine:masterfrom
bruvzg:svg_in_ot_sc_and_bl

Conversation

@bruvzg
Copy link
Copy Markdown
Member

@bruvzg bruvzg commented May 19, 2025

Fixes #106429
Fixes #80766
Fixes #98211

Before:
Screenshot 2025-05-19 at 09 29 45

After:
Screenshot 2025-05-19 at 09 29 26

@bruvzg bruvzg added this to the 4.5 milestone May 19, 2025
@bruvzg bruvzg requested a review from a team as a code owner May 19, 2025 06:34
@lvcivs
Copy link
Copy Markdown

lvcivs commented May 19, 2025

I tested this, it's much improved. But an issue mentioned in #98211 remains: there's a slight vertical shift when there are only emojis compared to when there are emojis mixed with text.

2025-05-19_13-41-15.mp4

@bruvzg
Copy link
Copy Markdown
Member Author

bruvzg commented May 19, 2025

there's a slight vertical shift when there are only emojis compared to when there are emojis mixed with text.

This looks expected, different fonts have different height, and height of the label depends on its content (in this particular case, baseline of hex boxes might need adjustment as well, but it's not related to SVG).

@Repiteo Repiteo merged commit 42302f0 into godotengine:master May 19, 2025
20 checks passed
@Repiteo
Copy link
Copy Markdown
Contributor

Repiteo commented May 19, 2025

Thanks!

@Koyper
Copy link
Copy Markdown
Contributor

Koyper commented May 19, 2025

This is excellent, but doesn't seem to have fixed #80766 using system emoji on MacOS.

Screenshot 2025-05-19 at 8 52 28 AM

@bruvzg
Copy link
Copy Markdown
Member Author

bruvzg commented May 19, 2025

system emoji on MacOS

macOS system emoji font is bitmap not SVG, so it is a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

5 participants